Repository navigation
Read pulserver's [Protocol] listing, so its sequences show their parameters and FOV - #13
Merged
Merged
Conversation
…meters and FOV pulserver delimits its protocol blocks with [Protocol]; the console read only [NimPulseqGUI Protocol], so every plugin listed no parameters and a scan sent no field of view. Both delimiters are read and [Protocol] is written. A boolean edited in a parameter tab travels as its value, not its text's truth. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Afq4fxyjbebF7KbvaNC1uh
…ces otherwise Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Afq4fxyjbebF7KbvaNC1uh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
Before: selecting a pulserver sequence in the virtual scanner showed no parameters in the Sequence tab, and resizing the FOV box changed nothing in the scan: the field of view was never sent.
After: each sequence's protocol entries appear in the Sequence tab, and the FOV planned on the localizer travels to pulserver as
fov,phase_fovandslice_thickness.pulserver delimits its protocol blocks with
[Protocol], while the console read only[NimPulseqGUI Protocol], so every listing parsed to nothing. Both delimiters are now read and[Protocol]is written (pulserver reads both). A boolean edited in a parameter tab comes back as text ("False"), which was sent astrue; it now travels as its value.How:
parse_listingaccepts either delimiter;format_valuesreads a textual boolean. Tests cover both delimiters and the boolean. Checked against pulserver main's reallistreply forgre2d: nine entries shown,fovandphase_fovamong them.🤖 Generated with Claude Code
https://claude.ai/code/session_01Afq4fxyjbebF7KbvaNC1uh
Generated by Claude Code